chrome/browser/chrome_browser_main_extra_parts.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chrome_browser_main_extra_parts.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/property_tree.h ('K') | « cc/trees/property_tree.cc ('k') | chrome/browser/chrome_content_browser_client_parts.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_	5 #ifndef CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_

6 #define CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_	6 #define CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_

7	7

8 // Interface class for Parts owned by ChromeBrowserMainParts.	8 // Interface class for Parts owned by ChromeBrowserMainParts.

9 // The default implementation for all methods is empty.	9 // The default implementation for all methods is empty.

10	10

(...skipping 22 matching lines...) Expand all Loading...
33 virtual void PostMainMessageLoopStart() {}	33 virtual void PostMainMessageLoopStart() {}

34	34

35 // MainMessageLoopRun methods.	35 // MainMessageLoopRun methods.

36 virtual void PreCreateThreads() {}	36 virtual void PreCreateThreads() {}

37 virtual void PreProfileInit() {}	37 virtual void PreProfileInit() {}

38 virtual void PostProfileInit() {}	38 virtual void PostProfileInit() {}

39 virtual void PreBrowserStart() {}	39 virtual void PreBrowserStart() {}

40 virtual void PostBrowserStart() {}	40 virtual void PostBrowserStart() {}

41 virtual void PreMainMessageLoopRun() {}	41 virtual void PreMainMessageLoopRun() {}

42 virtual void PostMainMessageLoopRun() {}	42 virtual void PostMainMessageLoopRun() {}

	43

	44 protected:

	45 ChromeBrowserMainExtraParts() = default;

43 };	46 };

44	47

45 #endif // CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_	48 #endif // CHROME_BROWSER_CHROME_BROWSER_MAIN_EXTRA_PARTS_H_

OLD	NEW