Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5401)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
index 14b2a4ec38dda404e7ed724058ca50159afabdf6..0be72021d15ea2c84637646fb9ceeb2ccbaccecf 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
@@ -376,12 +376,18 @@ bool ClipboardBookmarkManagerFunction::CopyOrCut(bool cut,
return true;
}
+BookmarkManagerPrivateCopyFunction::BookmarkManagerPrivateCopyFunction() =
+ default;
+
bool BookmarkManagerPrivateCopyFunction::RunOnReady() {
scoped_ptr<Copy::Params> params(Copy::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
return CopyOrCut(false, params->id_list);
}
+BookmarkManagerPrivateCutFunction::BookmarkManagerPrivateCutFunction() =
+ default;
+
bool BookmarkManagerPrivateCutFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -391,6 +397,9 @@ bool BookmarkManagerPrivateCutFunction::RunOnReady() {
return CopyOrCut(true, params->id_list);
}
+BookmarkManagerPrivatePasteFunction::BookmarkManagerPrivatePasteFunction() =
+ default;
+
bool BookmarkManagerPrivatePasteFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -422,6 +431,9 @@ bool BookmarkManagerPrivatePasteFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateCanPasteFunction::
+ BookmarkManagerPrivateCanPasteFunction() = default;
+
bool BookmarkManagerPrivateCanPasteFunction::RunOnReady() {
scoped_ptr<CanPaste::Params> params(CanPaste::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -443,6 +455,9 @@ bool BookmarkManagerPrivateCanPasteFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateSortChildrenFunction::
+ BookmarkManagerPrivateSortChildrenFunction() = default;
+
bool BookmarkManagerPrivateSortChildrenFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -540,6 +555,9 @@ bool BookmarkManagerPrivateGetStringsFunction::RunAsync() {
return true;
}
+BookmarkManagerPrivateStartDragFunction::
+ BookmarkManagerPrivateStartDragFunction() = default;
+
bool BookmarkManagerPrivateStartDragFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -571,6 +589,9 @@ bool BookmarkManagerPrivateStartDragFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateDropFunction::BookmarkManagerPrivateDropFunction() =
+ default;
+
bool BookmarkManagerPrivateDropFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -617,6 +638,9 @@ bool BookmarkManagerPrivateDropFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateGetSubtreeFunction::
+ BookmarkManagerPrivateGetSubtreeFunction() = default;
+
bool BookmarkManagerPrivateGetSubtreeFunction::RunOnReady() {
scoped_ptr<GetSubtree::Params> params(GetSubtree::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -642,6 +666,9 @@ bool BookmarkManagerPrivateGetSubtreeFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateCanEditFunction::BookmarkManagerPrivateCanEditFunction() =
+ default;
+
bool BookmarkManagerPrivateCanEditFunction::RunOnReady() {
PrefService* prefs = user_prefs::UserPrefs::Get(GetProfile());
SetResult(new base::FundamentalValue(
@@ -649,11 +676,17 @@ bool BookmarkManagerPrivateCanEditFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateRecordLaunchFunction::
+ BookmarkManagerPrivateRecordLaunchFunction() = default;
+
bool BookmarkManagerPrivateRecordLaunchFunction::RunOnReady() {
RecordBookmarkLaunch(NULL, BOOKMARK_LAUNCH_LOCATION_MANAGER);
return true;
}
+BookmarkManagerPrivateCreateWithMetaInfoFunction::
+ BookmarkManagerPrivateCreateWithMetaInfoFunction() = default;
+
bool BookmarkManagerPrivateCreateWithMetaInfoFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -676,6 +709,9 @@ bool BookmarkManagerPrivateCreateWithMetaInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateGetMetaInfoFunction::
+ BookmarkManagerPrivateGetMetaInfoFunction() = default;
+
bool BookmarkManagerPrivateGetMetaInfoFunction::RunOnReady() {
scoped_ptr<GetMetaInfo::Params> params(GetMetaInfo::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -727,6 +763,9 @@ bool BookmarkManagerPrivateGetMetaInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateSetMetaInfoFunction::
+ BookmarkManagerPrivateSetMetaInfoFunction() = default;
+
bool BookmarkManagerPrivateSetMetaInfoFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -751,6 +790,9 @@ bool BookmarkManagerPrivateSetMetaInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateUpdateMetaInfoFunction::
+ BookmarkManagerPrivateUpdateMetaInfoFunction() = default;
+
bool BookmarkManagerPrivateUpdateMetaInfoFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -783,12 +825,18 @@ bool BookmarkManagerPrivateUpdateMetaInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateCanOpenNewWindowsFunction::
+ BookmarkManagerPrivateCanOpenNewWindowsFunction() = default;
+
bool BookmarkManagerPrivateCanOpenNewWindowsFunction::RunOnReady() {
bool can_open_new_windows = true;
SetResult(new base::FundamentalValue(can_open_new_windows));
return true;
}
+BookmarkManagerPrivateRemoveTreesFunction::
+ BookmarkManagerPrivateRemoveTreesFunction() = default;
+
bool BookmarkManagerPrivateRemoveTreesFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -810,6 +858,9 @@ bool BookmarkManagerPrivateRemoveTreesFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateUndoFunction::BookmarkManagerPrivateUndoFunction() =
+ default;
+
bool BookmarkManagerPrivateUndoFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -819,6 +870,9 @@ bool BookmarkManagerPrivateUndoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateRedoFunction::BookmarkManagerPrivateRedoFunction() =
+ default;
+
bool BookmarkManagerPrivateRedoFunction::RunOnReady() {
if (!EditBookmarksEnabled())
return false;
@@ -828,6 +882,9 @@ bool BookmarkManagerPrivateRedoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateGetUndoInfoFunction::
+ BookmarkManagerPrivateGetUndoInfoFunction() = default;
+
bool BookmarkManagerPrivateGetUndoInfoFunction::RunOnReady() {
UndoManager* undo_manager =
BookmarkUndoServiceFactory::GetForProfile(GetProfile())->undo_manager();
@@ -840,6 +897,9 @@ bool BookmarkManagerPrivateGetUndoInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateGetRedoInfoFunction::
+ BookmarkManagerPrivateGetRedoInfoFunction() = default;
+
bool BookmarkManagerPrivateGetRedoInfoFunction::RunOnReady() {
UndoManager* undo_manager =
BookmarkUndoServiceFactory::GetForProfile(GetProfile())->undo_manager();
@@ -852,6 +912,9 @@ bool BookmarkManagerPrivateGetRedoInfoFunction::RunOnReady() {
return true;
}
+BookmarkManagerPrivateSetVersionFunction::
+ BookmarkManagerPrivateSetVersionFunction() = default;
+
bool BookmarkManagerPrivateSetVersionFunction::RunOnReady() {
scoped_ptr<SetVersion::Params> params = SetVersion::Params::Create(*args_);

Powered by Google App Engine
This is Rietveld 408576698