Fix classes that have too many virtuals for inline constructors.

cc/trees/property_tree.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_PROPERTY_TREE_H_
 #define CC_TREES_PROPERTY_TREE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 441 matching lines @@
   float device_scale_factor_;
   float device_transform_scale_factor_;
   gfx::Vector2dF inner_viewport_bounds_delta_;
   gfx::Vector2dF outer_viewport_bounds_delta_;
   std::vector<int> nodes_affected_by_inner_viewport_bounds_delta_;
   std::vector<int> nodes_affected_by_outer_viewport_bounds_delta_;
 };
 
 class CC_EXPORT ClipTree final : public PropertyTree<ClipNode> {
  public:
+  ClipTree();

[danakj, 2015/12/10 19:35:58]

Can you explain why this change? The base class has a virtual function and a
virtual destructor, both out-of-line. What makes the rule require this out of
line constructor?

[Jeffrey Yasskin, 2015/12/10 20:28:59]

There's a templated base class, which gives an initial score of 9:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi....
Then the vtable adds 3:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi...,
which puts the whole leaf class over 10.

+
   bool operator==(const ClipTree& other) const;
 
   void SetViewportClip(gfx::RectF viewport_rect);
   gfx::RectF ViewportClip();
 
   void ToProtobuf(proto::PropertyTree* proto) const;
   void FromProtobuf(const proto::PropertyTree& proto);
 };
 
 class CC_EXPORT EffectTree final : public PropertyTree<EffectNode> {
  public:
+  EffectTree();
+
   bool operator==(const EffectTree& other) const;
 
   void UpdateOpacities(int id);
 
   void ToProtobuf(proto::PropertyTree* proto) const;
   void FromProtobuf(const proto::PropertyTree& proto);
 };
 
 class CC_EXPORT PropertyTrees final {
  public:
   PropertyTrees();
 
   bool operator==(const PropertyTrees& other) const;
 
   void ToProtobuf(proto::PropertyTrees* proto) const;
   void FromProtobuf(const proto::PropertyTrees& proto);
 
   TransformTree transform_tree;
   EffectTree effect_tree;
   ClipTree clip_tree;
   bool needs_rebuild;
   bool non_root_surfaces_enabled;
   int sequence_number;
 };
 
 }  // namespace cc
 
 #endif  // CC_TREES_PROPERTY_TREE_H_