Fix classes that have too many virtuals for inline constructors.

cc/trees/property_tree.h

Index: cc/trees/property_tree.h
diff --git a/cc/trees/property_tree.h b/cc/trees/property_tree.h
index 4fbcc4312ca687609158779dcdda38acd9e972d1..49aec325b5507e0529e124daedad5b81842a122c 100644
--- a/cc/trees/property_tree.h
+++ b/cc/trees/property_tree.h
@@ -459,6 +459,8 @@ class CC_EXPORT TransformTree final : public PropertyTree<TransformNode> {
 
 class CC_EXPORT ClipTree final : public PropertyTree<ClipNode> {
  public:
+  ClipTree();

[danakj, 2015/12/10 19:35:58]

Can you explain why this change? The base class has a virtual function and a
virtual destructor, both out-of-line. What makes the rule require this out of
line constructor?

[Jeffrey Yasskin, 2015/12/10 20:28:59]

There's a templated base class, which gives an initial score of 9:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi....
Then the vtable adds 3:
https://codereview.chromium.org/1493813003/diff/100001/tools/clang/plugins/Fi...,
which puts the whole leaf class over 10.

+
   bool operator==(const ClipTree& other) const;
 
   void SetViewportClip(gfx::RectF viewport_rect);
@@ -470,6 +472,8 @@ class CC_EXPORT ClipTree final : public PropertyTree<ClipNode> {
 
 class CC_EXPORT EffectTree final : public PropertyTree<EffectNode> {
  public:
+  EffectTree();
+
   bool operator==(const EffectTree& other) const;
 
   void UpdateOpacities(int id);