Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: net/tools/balsa/balsa_frame.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_TOOLS_BALSA_BALSA_FRAME_H_ 5 #ifndef NET_TOOLS_BALSA_BALSA_FRAME_H_
6 #define NET_TOOLS_BALSA_BALSA_FRAME_H_ 6 #define NET_TOOLS_BALSA_BALSA_FRAME_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 193 }
194 return false; 194 return false;
195 } 195 }
196 196
197 inline bool HeaderFramingMayBeFound() const { 197 inline bool HeaderFramingMayBeFound() const {
198 return term_chars_ != 0; 198 return term_chars_ != 0;
199 } 199 }
200 200
201 private: 201 private:
202 class DoNothingBalsaVisitor : public BalsaVisitorInterface { 202 class DoNothingBalsaVisitor : public BalsaVisitorInterface {
203 public:
204 DoNothingBalsaVisitor();
205
206 private:
203 void ProcessBodyInput(const char* input, size_t size) override {} 207 void ProcessBodyInput(const char* input, size_t size) override {}
204 void ProcessBodyData(const char* input, size_t size) override {} 208 void ProcessBodyData(const char* input, size_t size) override {}
205 void ProcessHeaderInput(const char* input, size_t size) override {} 209 void ProcessHeaderInput(const char* input, size_t size) override {}
206 void ProcessTrailerInput(const char* input, size_t size) override {} 210 void ProcessTrailerInput(const char* input, size_t size) override {}
207 void ProcessHeaders(const BalsaHeaders& headers) override {} 211 void ProcessHeaders(const BalsaHeaders& headers) override {}
208 void ProcessRequestFirstLine(const char* line_input, 212 void ProcessRequestFirstLine(const char* line_input,
209 size_t line_length, 213 size_t line_length,
210 const char* method_input, 214 const char* method_input,
211 size_t method_length, 215 size_t method_length,
212 const char* request_uri_input, 216 const char* request_uri_input,
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 255
252 Lines lines_; 256 Lines lines_;
253 257
254 BalsaHeaders* headers_; // This is not reset to NULL in Reset(). 258 BalsaHeaders* headers_; // This is not reset to NULL in Reset().
255 DoNothingBalsaVisitor do_nothing_visitor_; 259 DoNothingBalsaVisitor do_nothing_visitor_;
256 }; 260 };
257 261
258 } // namespace net 262 } // namespace net
259 263
260 #endif // NET_TOOLS_BALSA_BALSA_FRAME_H_ 264 #endif // NET_TOOLS_BALSA_BALSA_FRAME_H_
261
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698