google_apis/gaia/gaia_auth_consumer.h - Issue 1499793003: Fix classes that have too many virtuals for inline constructors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: google_apis/gaia/gaia_auth_consumer.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity

Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« cc/trees/property_tree.h ('K') | « extensions/renderer/dispatcher_delegate.cc ('k') | ipc/ipc_test_channel_listener.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_	5 #ifndef GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_

6 #define GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_	6 #define GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_

7	7

8 #include <map>	8 #include <map>

9 #include <string>	9 #include <string>

10 #include <vector>	10 #include <vector>

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91	91

92 virtual void OnGetCheckConnectionInfoSuccess(const std::string& data) {}	92 virtual void OnGetCheckConnectionInfoSuccess(const std::string& data) {}

93 virtual void OnGetCheckConnectionInfoError(	93 virtual void OnGetCheckConnectionInfoError(

94 const GoogleServiceAuthError& error) {}	94 const GoogleServiceAuthError& error) {}

95	95

96 virtual void OnListIdpSessionsSuccess(const std::string& login_hint) {}	96 virtual void OnListIdpSessionsSuccess(const std::string& login_hint) {}

97 virtual void OnListIdpSessionsError(const GoogleServiceAuthError& error) {}	97 virtual void OnListIdpSessionsError(const GoogleServiceAuthError& error) {}

98	98

99 virtual void OnGetTokenResponseSuccess(const ClientOAuthResult& result) {}	99 virtual void OnGetTokenResponseSuccess(const ClientOAuthResult& result) {}

100 virtual void OnGetTokenResponseError(const GoogleServiceAuthError& error) {}	100 virtual void OnGetTokenResponseError(const GoogleServiceAuthError& error) {}

	101

	102 protected:

	103 GaiaAuthConsumer() = default;

101 };	104 };

102	105

103 #endif // GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_	106 #endif // GOOGLE_APIS_GAIA_GAIA_AUTH_CONSUMER_H_

OLD	NEW