Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: content/browser/appcache/appcache_storage.h

Issue 1499793003: Fix classes that have too many virtuals for inline constructors. Base URL: https://chromium.googlesource.com/chromium/src.git@enable-virtuals-as-complexity
Patch Set: Finish fixing the codebase that's accessible from Linux. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_ 5 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_
6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_ 6 #define CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // containing cache and group are also returned. 73 // containing cache and group are also returned.
74 virtual void OnMainResponseFound(const GURL& url, 74 virtual void OnMainResponseFound(const GURL& url,
75 const AppCacheEntry& entry, 75 const AppCacheEntry& entry,
76 const GURL& namespace_entry_url, 76 const GURL& namespace_entry_url,
77 const AppCacheEntry& fallback_entry, 77 const AppCacheEntry& fallback_entry,
78 int64_t cache_id, 78 int64_t cache_id,
79 int64_t group_id, 79 int64_t group_id,
80 const GURL& mainfest_url) {} 80 const GURL& mainfest_url) {}
81 81
82 protected: 82 protected:
83 Delegate() = default;
83 virtual ~Delegate() {} 84 virtual ~Delegate() {}
84 }; 85 };
85 86
86 explicit AppCacheStorage(AppCacheServiceImpl* service); 87 explicit AppCacheStorage(AppCacheServiceImpl* service);
87 virtual ~AppCacheStorage(); 88 virtual ~AppCacheStorage();
88 89
89 // Schedules a task to retrieve basic info about all groups and caches 90 // Schedules a task to retrieve basic info about all groups and caches
90 // stored in the system. Upon completion the delegate will be called 91 // stored in the system. Upon completion the delegate will be called
91 // with the results. 92 // with the results.
92 virtual void GetAllInfo(Delegate* delegate) = 0; 93 virtual void GetAllInfo(Delegate* delegate) = 0;
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 332
332 FRIEND_TEST_ALL_PREFIXES(content::AppCacheStorageTest, DelegateReferences); 333 FRIEND_TEST_ALL_PREFIXES(content::AppCacheStorageTest, DelegateReferences);
333 FRIEND_TEST_ALL_PREFIXES(content::AppCacheStorageTest, UsageMap); 334 FRIEND_TEST_ALL_PREFIXES(content::AppCacheStorageTest, UsageMap);
334 335
335 DISALLOW_COPY_AND_ASSIGN(AppCacheStorage); 336 DISALLOW_COPY_AND_ASSIGN(AppCacheStorage);
336 }; 337 };
337 338
338 } // namespace content 339 } // namespace content
339 340
340 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_ 341 #endif // CONTENT_BROWSER_APPCACHE_APPCACHE_STORAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698