Move extension notifications to extensions/browser/notification_types.h

Move extension notifications to extensions/browser/notification_types.h

As part of the extensions module refactor we temporarily allowed the use
of chrome_notification_types.h in src/extensions. However, this allowed
code moving into src/extensions to listen to notifications from Chrome,
which was a layering violation.

This CL moves all the extensions notifications into their own header and
cleans up DEPS to disallow the exception.

BUG=392622
TEST=compiles, unit_tests, browser_tests, extensions_unittests
TBR=miket@chromium.org for apps/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286770

[James Cook, 2014-07-30 16:51:46]

Scott, what do you think?  extensions/browser/notification_types.h has a note
about the renames that will be needed next.

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
File extensions/browser/notification_types.h (right):

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:10: //NOCOMMIT: This will become
"namespace extensions".
and will involve a global find/replace touching 133 files.

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:21: NOTIFICATION_CRX_INSTALLER_DONE,
These are copied in order from chrome_notification_types.h to make it obvious in
this diff that I got them all. I was thinking of alphabetizing them in the final
CL. Do you have an opinion?

[sky, 2014-07-30 17:31:40]

This seems fine to me.

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
File extensions/browser/notification_types.h (right):

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:16: enum ExtensionNotificationType {
You're going to drop the Extension here too, that is, just NotificationType,
right?

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:21: NOTIFICATION_CRX_INSTALLER_DONE,
On 2014/07/30 16:51:45, James Cook wrote:
> These are copied in order from chrome_notification_types.h to make it obvious
in
> this diff that I got them all. I was thinking of alphabetizing them in the
final
> CL. Do you have an opinion?

If you look in chrome/browser/chrome_notification_types.h you can see how we've
logically grouped things in certain areas. This is nice from the perspective of
minimizing where you might have to look for something.

We've gone with sorting of preference names. I tend favor grouping into
logically related areas, but I don't feel strongly.

[James Cook, 2014-07-30 22:36:34]

Scott, PTAL

This is the previous patch plus:
* Rename chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED to
chrome::NOTIFICATION_APP_LAUNCHER_REORDERED since it's about the NTP app
launcher, not extensions.
* Otherwise, rename chrome::NOTIFICATION_EXTENSION* to
extensions::NOTIFICATION_EXTENSION*
* Do some include-what-you-use header cleanup
* Fix some typos in chrome_notification_types.h

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
File extensions/browser/notification_types.h (right):

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:16: enum ExtensionNotificationType {
On 2014/07/30 17:31:39, sky wrote:
> You're going to drop the Extension here too, that is, just NotificationType,
> right?

Yes, this will become NotificationType (in namespace extensions).

https://codereview.chromium.org/425303002/diff/1/extensions/browser/notificat...
extensions/browser/notification_types.h:21: NOTIFICATION_CRX_INSTALLER_DONE,
On 2014/07/30 17:31:40, sky wrote:
> On 2014/07/30 16:51:45, James Cook wrote:
> > These are copied in order from chrome_notification_types.h to make it
obvious
> in
> > this diff that I got them all. I was thinking of alphabetizing them in the
> final
> > CL. Do you have an opinion?
> 
> If you look in chrome/browser/chrome_notification_types.h you can see how
we've
> logically grouped things in certain areas. This is nice from the perspective
of
> minimizing where you might have to look for something.
> 
> We've gone with sorting of preference names. I tend favor grouping into
> logically related areas, but I don't feel strongly.

I'll stick with the existing order, then, as it has logical grouping.

[sky, 2014-07-30 22:55:47]

LGTM

[James Cook, 2014-07-30 23:04:27]

Ken, can I get OWNERS for src/extensions?

If it looks good without nits, feel free to CQ it.

[Ken Rockot(use gerrit already), 2014-07-31 01:30:14]

lgtm

[Ken Rockot(use gerrit already), 2014-07-31 01:30:28]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-07-31 01:33:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamescook@chromium.org/425303002/20001

[James Cook, 2014-07-31 03:22:21]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2014-07-31 03:37:41]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2014-07-31 03:37:42]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2014-07-31 03:37:44]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-07-31 03:38:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamescook@chromium.org/425303002/40001

[commit-bot: I haz the power, 2014-07-31 12:44:17]

Change committed as 286770