Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index af8accd60f8cdb711b493cc5a4cf7f531141b551..dfbd3f1a414ad22c4fd568e18eb4c03a99d7d7d4 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -18,7 +18,6 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/extensions/api/developer_private/entry_picker.h"
#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
@@ -54,6 +53,7 @@
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/management_policy.h"
+#include "extensions/browser/notification_types.h"
#include "extensions/browser/view_type_utils.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_resource.h"
@@ -193,10 +193,10 @@ DeveloperPrivateAPI::DeveloperPrivateAPI(content::BrowserContext* context)
DeveloperPrivateEventRouter::DeveloperPrivateEventRouter(Profile* profile)
: extension_registry_observer_(this), profile_(profile) {
registrar_.Add(this,
- chrome::NOTIFICATION_EXTENSION_VIEW_REGISTERED,
+ extensions::NOTIFICATION_EXTENSION_VIEW_REGISTERED,
content::Source<Profile>(profile_));
registrar_.Add(this,
- chrome::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED,
+ extensions::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED,
content::Source<Profile>(profile_));
// TODO(limasdf): Use scoped_observer instead.
@@ -229,13 +229,13 @@ void DeveloperPrivateEventRouter::Observe(
developer::EventData event_data;
switch (type) {
- case chrome::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED: {
+ case extensions::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED: {
event_data.event_type = developer::EVENT_TYPE_VIEW_UNREGISTERED;
event_data.item_id = GetExtensionID(
content::Details<const RenderViewHost>(details).ptr());
break;
}
- case chrome::NOTIFICATION_EXTENSION_VIEW_REGISTERED: {
+ case extensions::NOTIFICATION_EXTENSION_VIEW_REGISTERED: {
event_data.event_type = developer::EVENT_TYPE_VIEW_REGISTERED;
event_data.item_id = GetExtensionID(
content::Details<const RenderViewHost>(details).ptr());
« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698