Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: extensions/shell/DEPS

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/shell/browser/shell_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # The apps module has dependencies on chrome. 2 # The apps module has dependencies on chrome.
3 "-apps", 3 "-apps",
4
4 # Individual subdirectories should have their own DEPS that include 5 # Individual subdirectories should have their own DEPS that include
5 # their allowed directories. 6 # their allowed directories.
6 "-extensions/shell", 7 "-extensions/shell",
7 "+extensions/shell/common", 8 "+extensions/shell/common",
8 "+extensions/shell/test", 9 "+extensions/shell/test",
9 10
10 # Do not add dependencies on Chrome. Talk to OWNERS about how to refactor 11 # Do not add dependencies on Chrome. Talk to OWNERS about how to refactor
11 # the code you need to a shared location. 12 # the code you need to a shared location.
12 "-chrome", 13 "-chrome",
13 14
14 # Only allow app_shell and extensions resources, not general Chrome ones. 15 # Only allow app_shell and extensions resources, not general Chrome ones.
15 "-grit", 16 "-grit",
16 "+grit/app_shell_resources.h", 17 "+grit/app_shell_resources.h",
17 "+grit/extensions_resources.h", 18 "+grit/extensions_resources.h",
18 19
19 # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS. 20 # Real DEPS go in subdirectories, for example extensions/shell/browser/DEPS.
20 # Temporary exceptions for app_shell bring-up go here.
21 # TODO(jamescook): Remove these. http://crbug.com/305404
22 "!chrome/browser/chrome_notification_types.h",
23 ] 21 ]
OLDNEW
« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/shell/browser/shell_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698