chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

index 35ff743009f10fc0b84d7941f089eae4da8d94ab..ef45ec529eb7028daad9f038563a8275e7d07078 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm

@@ -61,9 +61,9 @@ bool ExtensionKeybindingRegistryCocoa::ProcessKeyEvent(

int type = 0;

if (command_name == values::kPageActionCommandEvent) {

- type = chrome::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC;

+ type = extensions::NOTIFICATION_EXTENSION_COMMAND_PAGE_ACTION_MAC;

} else if (command_name == values::kBrowserActionCommandEvent) {

- type = chrome::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC;

+ type = extensions::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC;

} else {

// Not handled by using notifications. Route it through the Browser Event

// Router using the base class (it will iterate through all targets).