Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_browsertest.cc
diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc
index 5ceeb552e0bcee1fb6b3743c9422e458efeb5b15..9656e9d3edb9cdf8f63163c2292642aa214a0ead 100644
--- a/chrome/browser/extensions/api/management/management_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_browsertest.cc
@@ -8,7 +8,6 @@
#include "base/prefs/pref_service.h"
#include "base/prefs/scoped_user_pref_update.h"
#include "base/stl_util.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_test_message_listener.h"
@@ -28,6 +27,7 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
+#include "extensions/browser/notification_types.h"
#include "extensions/browser/pref_names.h"
#include "net/url_request/url_fetcher.h"
@@ -174,10 +174,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, DisableEnable) {
class NotificationListener : public content::NotificationObserver {
public:
NotificationListener() : started_(false), finished_(false) {
- int types[] = {
- chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED,
- chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND
- };
+ int types[] = {extensions::NOTIFICATION_EXTENSION_UPDATING_STARTED,
+ extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND};
for (size_t i = 0; i < arraysize(types); i++) {
registrar_.Add(
this, types[i], content::NotificationService::AllSources());
@@ -202,12 +200,12 @@ class NotificationListener : public content::NotificationObserver {
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE {
switch (type) {
- case chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED: {
+ case extensions::NOTIFICATION_EXTENSION_UPDATING_STARTED: {
EXPECT_FALSE(started_);
started_ = true;
break;
}
- case chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND: {
+ case extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND: {
const std::string& id =
content::Details<extensions::UpdateDetails>(details)->id;
updates_.insert(id);

Powered by Google App Engine
This is Rietveld 408576698