Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3713)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 021affd0209af46ca166381b541932eb1be34a69..f5294a50983e276a6b416150f0b57f568906cbaa 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -21,7 +21,6 @@
#include "base/threading/thread_restrictions.h"
#include "base/time/time.h"
#include "base/version.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/convert_user_script.h"
#include "chrome/browser/extensions/convert_web_app.h"
#include "chrome/browser/extensions/crx_installer_error.h"
@@ -45,6 +44,7 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/install_flag.h"
+#include "extensions/browser/notification_types.h"
#include "extensions/common/extension_icon_set.h"
#include "extensions/common/feature_switch.h"
#include "extensions/common/file_util.h"
@@ -750,7 +750,7 @@ void CrxInstaller::ReportFailureFromUIThread(const CrxInstallerError& error) {
content::NotificationService* service =
content::NotificationService::current();
- service->Notify(chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR,
+ service->Notify(extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR,
content::Source<CrxInstaller>(this),
content::Details<const base::string16>(&error.message()));
@@ -825,10 +825,9 @@ void CrxInstaller::NotifyCrxInstallComplete(bool success) {
// extension before it is unpacked, so they cannot filter based
// on the extension.
content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_CRX_INSTALLER_DONE,
+ extensions::NOTIFICATION_CRX_INSTALLER_DONE,
content::Source<CrxInstaller>(this),
- content::Details<const Extension>(
- success ? extension() : NULL));
+ content::Details<const Extension>(success ? extension() : NULL));
InstallTrackerFactory::GetForBrowserContext(profile())
->OnFinishCrxInstall(success ? extension()->id() : expected_id_, success);
« no previous file with comments | « chrome/browser/extensions/convert_web_app_browsertest.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698