Move extension notifications to extensions/browser/notification_types.h

extensions/browser/process_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/process_manager.h"
 
-#include "chrome/browser/chrome_notification_types.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/common/content_client.h"
 #include "content/public/test/test_browser_context.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extensions_test.h"
+#include "extensions/browser/notification_types.h"
 #include "extensions/browser/process_manager_delegate.h"
 #include "extensions/browser/test_extensions_browser_client.h"
 
 using content::BrowserContext;
 using content::SiteInstance;
 using content::TestBrowserContext;
 
 namespace extensions {
 
 namespace {
@@ skipping 76 matching lines @@
 TEST_F(ProcessManagerTest, ExtensionNotificationRegistration) {
   // Test for a normal context ProcessManager.
   scoped_ptr<ProcessManager> manager1(ProcessManager::CreateForTesting(
       original_context(), extension_registry()));
 
   EXPECT_EQ(original_context(), manager1->GetBrowserContext());
   EXPECT_EQ(0u, manager1->background_hosts().size());
 
   // It observes other notifications from this context.
   EXPECT_TRUE(IsRegistered(manager1.get(),
-                           chrome::NOTIFICATION_EXTENSIONS_READY,
+                           extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
                            original_context()));
   EXPECT_TRUE(IsRegistered(manager1.get(),
-                           chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
+                           extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
                            original_context()));
+  EXPECT_TRUE(
+      IsRegistered(manager1.get(),
+                   extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
+                   original_context()));
   EXPECT_TRUE(IsRegistered(manager1.get(),
-                           chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
-                           original_context()));
-  EXPECT_TRUE(IsRegistered(manager1.get(),
-                           chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED,
+                           extensions::NOTIFICATION_EXTENSION_HOST_DESTROYED,
                            original_context()));
 
   // Test for an incognito context ProcessManager.
   scoped_ptr<ProcessManager> manager2(
       ProcessManager::CreateIncognitoForTesting(incognito_context(),
                                                 original_context(),
                                                 manager1.get(),
                                                 extension_registry()));
 
   EXPECT_EQ(incognito_context(), manager2->GetBrowserContext());
   EXPECT_EQ(0u, manager2->background_hosts().size());
 
   // Some notifications are observed for the original context.
   EXPECT_TRUE(IsRegistered(manager2.get(),
-                           chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
+                           extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
                            original_context()));
 
   // Some notifications are observed for the incognito context.
   EXPECT_TRUE(IsRegistered(manager2.get(),
-                           chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED,
+                           extensions::NOTIFICATION_EXTENSION_HOST_DESTROYED,
                            incognito_context()));
 
   // Some are not observed at all.
-  EXPECT_FALSE(IsRegistered(manager2.get(),
-                            chrome::NOTIFICATION_EXTENSIONS_READY,
-                            original_context()));
+  EXPECT_FALSE(
+      IsRegistered(manager2.get(),
+                   extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
+                   original_context()));
 }
 
 // Test that startup background hosts are created when the extension system
 // becomes ready.
 //
 // NOTE: This test and those that follow do not try to create ExtensionsHosts
 // because ExtensionHost is tightly coupled to WebContents and can't be
 // constructed in unit tests.
 TEST_F(ProcessManagerTest, CreateBackgroundHostsOnExtensionsReady) {
   scoped_ptr<ProcessManager> manager(ProcessManager::CreateForTesting(
       original_context(), extension_registry()));
   ASSERT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // Simulate the extension system becoming ready.
   content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_EXTENSIONS_READY,
+      extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
       content::Source<BrowserContext>(original_context()),
       content::NotificationService::NoDetails());
   EXPECT_TRUE(manager->startup_background_hosts_created_for_test());
 }
 
 // Test that startup background hosts can be created explicitly before the
 // extension system is ready (this is the normal pattern in Chrome).
 TEST_F(ProcessManagerTest, CreateBackgroundHostsExplicitly) {
   scoped_ptr<ProcessManager> manager(ProcessManager::CreateForTesting(
       original_context(), extension_registry()));
@@ skipping 12 matching lines @@
       original_context(), extension_registry()));
   ASSERT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // Don't create background hosts if the delegate says to defer them.
   process_manager_delegate()->defer_creating_startup_background_hosts_ = true;
   manager->MaybeCreateStartupBackgroundHosts();
   EXPECT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // The extension system becoming ready still doesn't create the hosts.
   content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_EXTENSIONS_READY,
+      extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
       content::Source<BrowserContext>(original_context()),
       content::NotificationService::NoDetails());
   EXPECT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // Once the embedder is ready the background hosts can be created.
   process_manager_delegate()->defer_creating_startup_background_hosts_ = false;
   manager->MaybeCreateStartupBackgroundHosts();
   EXPECT_TRUE(manager->startup_background_hosts_created_for_test());
 }
 
 // Test that the embedder can disallow background host creation.
 // Chrome OS does this in guest mode.
 TEST_F(ProcessManagerTest, IsBackgroundHostAllowed) {
   scoped_ptr<ProcessManager> manager(ProcessManager::CreateForTesting(
       original_context(), extension_registry()));
   ASSERT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // Don't create background hosts if the delegate disallows them.
   process_manager_delegate()->is_background_page_allowed_ = false;
   manager->MaybeCreateStartupBackgroundHosts();
   EXPECT_FALSE(manager->startup_background_hosts_created_for_test());
 
   // The extension system becoming ready still doesn't create the hosts.
   content::NotificationService::current()->Notify(
-      chrome::NOTIFICATION_EXTENSIONS_READY,
+      extensions::NOTIFICATION_EXTENSIONS_READY_DEPRECATED,
       content::Source<BrowserContext>(original_context()),
       content::NotificationService::NoDetails());
   EXPECT_FALSE(manager->startup_background_hosts_created_for_test());
 }
 
 // Test that extensions get grouped in the right SiteInstance (and therefore
 // process) based on their URLs.
 TEST_F(ProcessManagerTest, ProcessGrouping) {
   // Extensions in different browser contexts should always be different
   // SiteInstances.
@@ skipping 21 matching lines @@
   scoped_refptr<SiteInstance> site21 =
       manager1->GetSiteInstanceForURL(ext2_url1);
   EXPECT_NE(site11, site21);
 
   scoped_refptr<SiteInstance> other_profile_site =
       manager2->GetSiteInstanceForURL(ext1_url1);
   EXPECT_NE(site11, other_profile_site);
 }
 
 }  // namespace extensions