chrome/browser/extensions/webstore_installer.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/user_script_master_unittest.cc ('k') | chrome/browser/extensions/webstore_startup_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 364a3e3649f8232615c48f4683d7c8cd8d0f57e9..6bfa00f1d84e353e8cda552c84a63fcacf75b5fc 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -290,7 +290,8 @@ WebstoreInstaller::WebstoreInstaller(Profile* profile,

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(web_contents);

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR,

+ registrar_.Add(this,

+ extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR,

content::Source<CrxInstaller>(NULL));

extension_registry_observer_.Add(ExtensionRegistry::Get(profile));

}

@@ -360,7 +361,7 @@ void WebstoreInstaller::Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR: {

+ case extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR: {

CrxInstaller* crx_installer = content::Source<CrxInstaller>(source).ptr();

CHECK(crx_installer);

if (crx_installer != crx_installer_.get())