Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/extensions/updater/extension_updater.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_updater.cc
diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc
index 5e1bbbf128a7712c73b116ee4fa338701de8fd33..0aa1ac0bc4e5ebf7c2546d06a49d7461ae17dee7 100644
--- a/chrome/browser/extensions/updater/extension_updater.cc
+++ b/chrome/browser/extensions/updater/extension_updater.cc
@@ -573,7 +573,7 @@ void ExtensionUpdater::MaybeInstallCRXFile() {
// Source parameter ensures that we only see the completion event for the
// the installer we started.
registrar_.Add(this,
- chrome::NOTIFICATION_CRX_INSTALLER_DONE,
+ extensions::NOTIFICATION_CRX_INSTALLER_DONE,
content::Source<CrxInstaller>(installer));
} else {
for (std::set<int>::const_iterator it = crx_file.request_ids.begin();
@@ -596,11 +596,9 @@ void ExtensionUpdater::MaybeInstallCRXFile() {
void ExtensionUpdater::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
- DCHECK_EQ(type, chrome::NOTIFICATION_CRX_INSTALLER_DONE);
+ DCHECK_EQ(type, extensions::NOTIFICATION_CRX_INSTALLER_DONE);
- registrar_.Remove(this,
- chrome::NOTIFICATION_CRX_INSTALLER_DONE,
- source);
+ registrar_.Remove(this, extensions::NOTIFICATION_CRX_INSTALLER_DONE, source);
crx_install_is_running_ = false;
const FetchedCRXFile& crx_file = current_crx_file_;
@@ -626,7 +624,7 @@ void ExtensionUpdater::OnExtensionWillBeInstalled(
void ExtensionUpdater::NotifyStarted() {
content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_EXTENSION_UPDATING_STARTED,
+ extensions::NOTIFICATION_EXTENSION_UPDATING_STARTED,
content::Source<Profile>(profile_),
content::NotificationService::NoDetails());
}

Powered by Google App Engine
This is Rietveld 408576698