chrome/browser/extensions/extension_error_reporter.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_error_reporter.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/extension_functional_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_error_reporter.cc

diff --git a/chrome/browser/extensions/extension_error_reporter.cc b/chrome/browser/extensions/extension_error_reporter.cc

index eb28566878954d3b14aafc88a8befcc3c35e530f..4e5b95645cfeb816e6b4850a82243c758a30b292 100644

--- a/chrome/browser/extensions/extension_error_reporter.cc

+++ b/chrome/browser/extensions/extension_error_reporter.cc

@@ -13,10 +13,10 @@

#include "base/message_loop/message_loop.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/simple_message_box.h"

#include "content/public/browser/notification_service.h"

+#include "extensions/browser/notification_types.h"

ExtensionErrorReporter* ExtensionErrorReporter::instance_ = NULL;

@@ -46,7 +46,7 @@ void ExtensionErrorReporter::ReportLoadError(

content::BrowserContext* browser_context,

bool be_noisy) {

content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_EXTENSION_LOAD_ERROR,

+ extensions::NOTIFICATION_EXTENSION_LOAD_ERROR,

content::Source<Profile>(Profile::FromBrowserContext(browser_context)),

content::Details<const std::string>(&error));