Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/extensions/api/commands/command_service.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/commands/command_service.cc
diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc
index ddcf18e06417c803f6024648fa06fbdd881e1ec8..a448bf26f090598c254e3261b7e9dacbb0e458d6 100644
--- a/chrome/browser/extensions/api/commands/command_service.cc
+++ b/chrome/browser/extensions/api/commands/command_service.cc
@@ -12,7 +12,6 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/api/commands/commands.h"
#include "chrome/browser/extensions/extension_commands_global_registry.h"
#include "chrome/browser/extensions/extension_keybinding_registry.h"
@@ -28,6 +27,7 @@
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_system.h"
+#include "extensions/browser/notification_types.h"
#include "extensions/common/feature_switch.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/permissions/permissions_data.h"
@@ -286,10 +286,10 @@ bool CommandService::AddKeybindingPref(
std::pair<const std::string, const std::string> details =
std::make_pair(extension_id, command_name);
content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_EXTENSION_COMMAND_ADDED,
+ extensions::NOTIFICATION_EXTENSION_COMMAND_ADDED,
content::Source<Profile>(profile_),
- content::Details<
- std::pair<const std::string, const std::string> >(&details));
+ content::Details<std::pair<const std::string, const std::string> >(
+ &details));
return true;
}
@@ -804,10 +804,10 @@ void CommandService::RemoveKeybindingPrefs(const std::string& extension_id,
std::pair<const std::string, const std::string> details =
std::make_pair(extension_id, command_name);
content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_EXTENSION_COMMAND_REMOVED,
+ extensions::NOTIFICATION_EXTENSION_COMMAND_REMOVED,
content::Source<Profile>(profile_),
- content::Details<
- std::pair<const std::string, const std::string> >(&details));
+ content::Details<std::pair<const std::string, const std::string> >(
+ &details));
}
}

Powered by Google App Engine
This is Rietveld 408576698