Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/devtools/devtools_window.h" 10 #include "chrome/browser/devtools/devtools_window.h"
(...skipping 1403 matching lines...) Expand 10 before | Expand all | Expand 10 after
1414 chrome::NOTIFICATION_PANEL_CLOSED, 1414 chrome::NOTIFICATION_PANEL_CLOSED,
1415 content::Source<Panel>(panel)); 1415 content::Source<Panel>(panel));
1416 content::WindowedNotificationObserver signal1( 1416 content::WindowedNotificationObserver signal1(
1417 chrome::NOTIFICATION_PANEL_CLOSED, 1417 chrome::NOTIFICATION_PANEL_CLOSED,
1418 content::Source<Panel>(panel1)); 1418 content::Source<Panel>(panel1));
1419 1419
1420 // Send unload notification on the first extension. 1420 // Send unload notification on the first extension.
1421 extensions::UnloadedExtensionInfo details( 1421 extensions::UnloadedExtensionInfo details(
1422 extension.get(), extensions::UnloadedExtensionInfo::REASON_UNINSTALL); 1422 extension.get(), extensions::UnloadedExtensionInfo::REASON_UNINSTALL);
1423 content::NotificationService::current()->Notify( 1423 content::NotificationService::current()->Notify(
1424 chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED, 1424 extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
1425 content::Source<Profile>(browser()->profile()), 1425 content::Source<Profile>(browser()->profile()),
1426 content::Details<extensions::UnloadedExtensionInfo>(&details)); 1426 content::Details<extensions::UnloadedExtensionInfo>(&details));
1427 1427
1428 // Wait for the panels opened by the first extension to close. 1428 // Wait for the panels opened by the first extension to close.
1429 signal.Wait(); 1429 signal.Wait();
1430 signal1.Wait(); 1430 signal1.Wait();
1431 1431
1432 // Verify that the panel that's left is the panel from the second extension. 1432 // Verify that the panel that's left is the panel from the second extension.
1433 EXPECT_EQ(panel_other, panel_manager->panels()[0]); 1433 EXPECT_EQ(panel_other, panel_manager->panels()[0]);
1434 panel_other->Close(); 1434 panel_other->Close();
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
1773 #else 1773 #else
1774 #define MAYBE_FocusChangeEventOnMinimize FocusChangeEventOnMinimize 1774 #define MAYBE_FocusChangeEventOnMinimize FocusChangeEventOnMinimize
1775 #endif 1775 #endif
1776 IN_PROC_BROWSER_TEST_F(PanelExtensionApiTest, 1776 IN_PROC_BROWSER_TEST_F(PanelExtensionApiTest,
1777 MAYBE_FocusChangeEventOnMinimize) { 1777 MAYBE_FocusChangeEventOnMinimize) {
1778 // This is needed so the subsequently created panels can be activated. 1778 // This is needed so the subsequently created panels can be activated.
1779 // On a Mac, it transforms background-only test process into foreground one. 1779 // On a Mac, it transforms background-only test process into foreground one.
1780 ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser())); 1780 ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
1781 ASSERT_TRUE(RunExtensionTest("panels/focus_change_on_minimize")) << message_; 1781 ASSERT_TRUE(RunExtensionTest("panels/focus_change_on_minimize")) << message_;
1782 } 1782 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/views/extensions/extension_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698