chrome/browser/extensions/external_install_manager.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_manager.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_view_host.cc ('k') | chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_manager.cc

diff --git a/chrome/browser/extensions/external_install_manager.cc b/chrome/browser/extensions/external_install_manager.cc

index 9004bcc2571e4498d0ea588a7ea0e93c1ecd6c41..2488458309e56301beff2ed66f50e71b75aaf0ca 100644

--- a/chrome/browser/extensions/external_install_manager.cc

+++ b/chrome/browser/extensions/external_install_manager.cc

@@ -68,7 +68,7 @@ ExternalInstallManager::ExternalInstallManager(

extension_registry_observer_.Add(ExtensionRegistry::Get(browser_context_));

registrar_.Add(

this,

- chrome::NOTIFICATION_EXTENSION_REMOVED,

+ extensions::NOTIFICATION_EXTENSION_REMOVED,

content::Source<Profile>(Profile::FromBrowserContext(browser_context_)));

}

@@ -216,7 +216,7 @@ void ExternalInstallManager::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- DCHECK_EQ(chrome::NOTIFICATION_EXTENSION_REMOVED, type);

+ DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_REMOVED, type);

// The error is invalidated if the extension has been loaded or removed.

// It's a shame we have to use the notification system (instead of the

// registry observer) for this, but the ExtensionUnloaded notification is