chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api.cc ('k') | chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index bc743e98da9645fc6797a137a6c64454c54dfcbc..a5acea53cdb55c3f58021c28410f83efbce36d75 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -7,7 +7,6 @@

#include "base/message_loop/message_loop.h"

#include "base/metrics/histogram.h"

#include "base/time/time.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_warning_service.h"

#include "chrome/browser/extensions/extension_warning_set.h"

@@ -19,6 +18,7 @@

#include "components/omaha_query_params/omaha_query_params.h"

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/notification_types.h"

#include "extensions/common/api/runtime.h"

#if defined(OS_CHROMEOS)

@@ -53,7 +53,7 @@ ChromeRuntimeAPIDelegate::ChromeRuntimeAPIDelegate(

content::BrowserContext* context)

: browser_context_(context), registered_for_updates_(false) {

registrar_.Add(this,

- chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND,

+ extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND,

content::NotificationService::AllSources());

}

@@ -245,7 +245,7 @@ void ChromeRuntimeAPIDelegate::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- DCHECK(type == chrome::NOTIFICATION_EXTENSION_UPDATE_FOUND);

+ DCHECK(type == extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND);

typedef const std::pair<std::string, Version> UpdateDetails;

const std::string& id = content::Details<UpdateDetails>(details)->first;

const Version& version = content::Details<UpdateDetails>(details)->second;