chrome/browser/extensions/api/bookmarks/bookmarks_api.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc ('k') | chrome/browser/extensions/api/commands/command_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

index d3e3cbe534ea0d03a2874e374dd5b4122e3ef6e3..8361b9482bdf2622eaa7c0e1a412857620f33249 100644

--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

@@ -26,7 +26,6 @@

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client.h"

#include "chrome/browser/bookmarks/chrome_bookmark_client_factory.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h"

#include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"

#include "chrome/browser/importer/external_process_importer_host.h"

@@ -48,6 +47,7 @@

#include "extensions/browser/event_router.h"

#include "extensions/browser/extension_function_dispatcher.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/notification_types.h"

#include "extensions/common/permissions/permissions_data.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -156,7 +156,7 @@ bool BookmarksFunction::RunAsync() {

bool success = RunOnReady();

if (success) {

content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_EXTENSION_BOOKMARKS_API_INVOKED,

+ extensions::NOTIFICATION_EXTENSION_BOOKMARKS_API_INVOKED,

content::Source<const Extension>(extension()),

content::Details<const BookmarksFunction>(this));

}