chrome/browser/extensions/extension_infobar_delegate.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_infobar_delegate.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | chrome/browser/extensions/extension_install_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_infobar_delegate.cc

diff --git a/chrome/browser/extensions/extension_infobar_delegate.cc b/chrome/browser/extensions/extension_infobar_delegate.cc

index e7695199278f9aec1b1e81678bc7dee64f0fa910..ba169600b5184f53265edb06f9aec89053285566 100644

--- a/chrome/browser/extensions/extension_infobar_delegate.cc

+++ b/chrome/browser/extensions/extension_infobar_delegate.cc

@@ -50,7 +50,8 @@ ExtensionInfoBarDelegate::ExtensionInfoBarDelegate(

extension_registry_observer_.Add(

extensions::ExtensionRegistry::Get(browser->profile()));

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,

+ registrar_.Add(this,

+ extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,

content::Source<Profile>(browser->profile()));

height_ = std::max(0, height);

@@ -109,7 +110,7 @@ void ExtensionInfoBarDelegate::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- DCHECK_EQ(type, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE);

+ DCHECK_EQ(type, extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE);

if (extension_view_host_.get() ==

content::Details<extensions::ExtensionHost>(details).ptr())

infobar()->RemoveSelf();