chrome/browser/extensions/extension_install_ui_browsertest.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_browsertest.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_infobar_delegate.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui_browsertest.cc

diff --git a/chrome/browser/extensions/extension_install_ui_browsertest.cc b/chrome/browser/extensions/extension_install_ui_browsertest.cc

index 2fde73bcd1bb1ce29ff2044d0280d7d398fbad25..ba9fca2a32b43e12e53845c5193c2e5034eca0ab 100644

--- a/chrome/browser/extensions/extension_install_ui_browsertest.cc

+++ b/chrome/browser/extensions/extension_install_ui_browsertest.cc

@@ -200,7 +200,7 @@ class NewTabUISortingBrowserTest : public ExtensionInstallUIBrowserTest,

virtual void Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) OVERRIDE {

- if (type != chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED) {

+ if (type != chrome::NOTIFICATION_APP_LAUNCHER_REORDERED) {

observer_->Observe(type, source, details);

return;

}

@@ -233,8 +233,9 @@ IN_PROC_BROWSER_TEST_F(NewTabUISortingBrowserTest,

extensions::ExtensionPrefs::Get(browser()->profile())->app_sorting();

// Register for notifications in the same way as AppLauncherHandler.

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED,

- content::Source<AppSorting>(sorting));

+ registrar_.Add(this,

+ chrome::NOTIFICATION_APP_LAUNCHER_REORDERED,

+ content::Source<AppSorting>(sorting));

// ExtensionAppItem calls this when an app install starts.

sorting->EnsureValidOrdinals(app_id, syncer::StringOrdinal());

// Vefify the app is not actually installed yet.