chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/operation_manager.cc ('k') | chrome/browser/extensions/api/management/management_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index a9e395c87a3b909e1fad09b552e1b72efc300404..7f36d233950d20282c7d9844e6468704ab7fc5ba 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -6,7 +6,6 @@

#include "base/files/scoped_temp_dir.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/api/management/management_api.h"

#include "chrome/browser/extensions/api/management/management_api_constants.h"

#include "chrome/browser/extensions/extension_browsertest.h"

@@ -22,6 +21,7 @@

#include "extensions/browser/extension_host.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/browser/notification_types.h"

namespace keys = extension_management_api_constants;

namespace util = extension_function_test_utils;

@@ -297,7 +297,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,

// crash it. (NOTIFICATION_RENDERER_PROCESS_CREATED does not wait for the

// latter and can cause KillProcess to fail on Windows.)

content::WindowedNotificationObserver observer(

- chrome::NOTIFICATION_EXTENSION_HOST_CREATED,

+ extensions::NOTIFICATION_EXTENSION_HOST_CREATED,

content::NotificationService::AllSources());

ExtensionInstallPrompt::g_auto_confirm_for_tests =

ExtensionInstallPrompt::ACCEPT;