chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 01f53d49590c1f8b0324de02d8ab136ce076186e..2e7f6b97f83372f4d90557c230152a188410686d 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -61,10 +61,11 @@ class ExtensionLoadedNotificationObserver

ExtensionInstalledBubbleController* controller, Profile* profile)

: controller_(controller) {

registrar_.Add(this,

- chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

+ extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

+ content::Source<Profile>(profile));

+ registrar_.Add(this,

+ extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

content::Source<Profile>(profile));

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

- content::Source<Profile>(profile));

}

private:

@@ -74,7 +75,7 @@ class ExtensionLoadedNotificationObserver

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) OVERRIDE {

- if (type == chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED) {

+ if (type == extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED) {

const Extension* extension =

content::Details<const Extension>(details).ptr();

if (extension == [controller_ extension]) {

@@ -82,7 +83,7 @@ class ExtensionLoadedNotificationObserver

withObject:controller_

waitUntilDone:NO];

}

- } else if (type == chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED) {

+ } else if (type == extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED) {

const Extension* extension =

content::Details<const UnloadedExtensionInfo>(details)->extension;

if (extension == [controller_ extension]) {