Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_view.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_action_view.cc b/chrome/browser/ui/views/toolbar/browser_action_view.cc
index 149148aef0d0a9d3d01b2a1d6c1c38028d6df924..cd891b842c8ef9e8e0abcd06b424c04dccdb77e8 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/browser_action_view.cc
@@ -120,11 +120,14 @@ BrowserActionButton::BrowserActionButton(const Extension* extension,
content::NotificationSource notification_source =
content::Source<Profile>(browser_->profile()->GetOriginalProfile());
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,
+ registrar_.Add(this,
+ extensions::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,
content::Source<ExtensionAction>(browser_action_));
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_COMMAND_ADDED,
+ registrar_.Add(this,
+ extensions::NOTIFICATION_EXTENSION_COMMAND_ADDED,
notification_source);
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_COMMAND_REMOVED,
+ registrar_.Add(this,
+ extensions::NOTIFICATION_EXTENSION_COMMAND_REMOVED,
notification_source);
// We also listen for browser theme changes on linux because a switch from or
@@ -275,21 +278,21 @@ void BrowserActionButton::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED:
+ case extensions::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED:
UpdateState();
// The browser action may have become visible/hidden so we need to make
// sure the state gets updated.
delegate_->OnBrowserActionVisibilityChanged();
break;
- case chrome::NOTIFICATION_EXTENSION_COMMAND_ADDED:
- case chrome::NOTIFICATION_EXTENSION_COMMAND_REMOVED: {
+ case extensions::NOTIFICATION_EXTENSION_COMMAND_ADDED:
+ case extensions::NOTIFICATION_EXTENSION_COMMAND_REMOVED: {
std::pair<const std::string, const std::string>* payload =
content::Details<std::pair<const std::string, const std::string> >(
details).ptr();
if (extension_->id() == payload->first &&
payload->second ==
extensions::manifest_values::kBrowserActionCommandEvent) {
- if (type == chrome::NOTIFICATION_EXTENSION_COMMAND_ADDED)
+ if (type == extensions::NOTIFICATION_EXTENSION_COMMAND_ADDED)
MaybeRegisterExtensionCommand();
else
MaybeUnregisterExtensionCommand(true);

Powered by Google App Engine
This is Rietveld 408576698