chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index 1e88c844d051f63abcf93eeacc951778b1614c6e..5bc804be3f6796f9680bbc1ab5a8ea6210875aee 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -127,7 +127,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

const content::NotificationSource& source,

const content::NotificationDetails& details) OVERRIDE {

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {

+ case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING: {

if (content::Details<extensions::ExtensionViewHost>(

[controller_ extensionViewHost]) == details) {

[controller_ showDevTools];

@@ -195,7 +195,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {

// Listen for the extension to finish loading so the dev tools can be

// opened.

registrar_->Add(notificationBridge_.get(),

- chrome::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,

+ extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_LOADING,

content::Source<BrowserContext>(host->browser_context()));

}