chrome/browser/extensions/api/notifications/notifications_apitest.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_apitest.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

index 7c6a97b8d827295ce63103726d4cc5e870aefad1..8cfa4a210c5bdcfa15e23f1e9c8cd45197f4c56f 100644

--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

@@ -6,7 +6,6 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/api/notifications/notifications_api.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

@@ -15,6 +14,7 @@

#include "content/public/browser/notification_service.h"

#include "content/public/test/test_utils.h"

#include "extensions/browser/api/test/test_api.h"

+#include "extensions/browser/notification_types.h"

#include "extensions/common/features/feature.h"

#include "ui/message_center/message_center.h"

#include "ui/message_center/notification_list.h"

@@ -32,7 +32,7 @@ class UserGestureCatcher : public content::NotificationObserver {

public:

UserGestureCatcher() : waiting_(false) {

registrar_.Add(this,

- chrome::NOTIFICATION_EXTENSION_TEST_MESSAGE,

+ extensions::NOTIFICATION_EXTENSION_TEST_MESSAGE,

content::NotificationService::AllSources());

}

@@ -83,7 +83,7 @@ class NotificationsApiTest : public ExtensionApiTest {

const std::string& test_name) {

base::FilePath extdir = test_data_dir_.AppendASCII(test_name);

content::WindowedNotificationObserver page_created(

- chrome::NOTIFICATION_EXTENSION_BACKGROUND_PAGE_READY,

+ extensions::NOTIFICATION_EXTENSION_BACKGROUND_PAGE_READY,

content::NotificationService::AllSources());

const extensions::Extension* extension = LoadExtension(extdir);

if (extension) {