chrome/browser/extensions/extension_toolbar_model.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_test_notification_observer.cc ('k') | chrome/browser/extensions/extension_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_toolbar_model.cc

diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc

index d155b4ac8aa6841f9d377d2e6a2c15c6c9fdd185..fd8fa3b246048ba1aa154ba52889d4777422b005 100644

--- a/chrome/browser/extensions/extension_toolbar_model.cc

+++ b/chrome/browser/extensions/extension_toolbar_model.cc

@@ -210,8 +210,9 @@ void ExtensionToolbarModel::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- DCHECK_EQ(chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,

- type);

+ DCHECK_EQ(

+ extensions::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,

+ type);

const Extension* extension =

ExtensionRegistry::Get(profile_)->GetExtensionById(

*content::Details<const std::string>(details).ptr(),

@@ -232,7 +233,7 @@ void ExtensionToolbarModel::OnReady() {

extension_registry_observer_.Add(registry);

registrar_.Add(

this,

- chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,

+ extensions::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,

content::Source<ExtensionPrefs>(extension_prefs_));

}