chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index ceb3cd8539176927d1059a8257b80a667fdfd375..6097e7704e677addda4ec725481ca43acd7dfa5b 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -26,7 +26,6 @@

#include "base/task/cancelable_task_tracker.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/download/download_danger_prompt.h"

#include "chrome/browser/download/download_file_icon_extractor.h"

#include "chrome/browser/download/download_prefs.h"

@@ -64,6 +63,7 @@

#include "extensions/browser/extension_function_dispatcher.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/browser/notification_types.h"

#include "extensions/common/permissions/permissions_data.h"

#include "net/base/filename_util.h"

#include "net/base/load_flags.h"

@@ -1911,7 +1911,7 @@ void ExtensionDownloadsEventRouter::DispatchEvent(

content::Source<DownloadsNotificationSource> content_source(

&notification_source);

content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_EXTENSION_DOWNLOADS_EVENT,

+ extensions::NOTIFICATION_EXTENSION_DOWNLOADS_EVENT,

content_source,

content::Details<std::string>(&json_args));

}