chrome/browser/ui/views/extensions/extension_popup.cc - Issue 425303002: Move extension notifications to extensions/browser/notification_types.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 425303002: Move extension notifications to extensions/browser/notification_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: (extension-notifications) rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_dialog.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index 68b0868f98910adef5cff528f9c19403cbe544fd..06a8bc02159f410f46bd9fb0c2efd01aeb147a9c 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -65,7 +65,9 @@ ExtensionPopup::ExtensionPopup(extensions::ExtensionViewHost* host,

content::Source<content::WebContents>(host->host_contents()));

// Listen for the containing view calling window.close();

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,

+ registrar_.Add(

+ this,

+ extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE,

content::Source<content::BrowserContext>(host->browser_context()));

content::DevToolsManager::GetInstance()->AddAgentStateCallback(

devtools_callback_);

@@ -91,7 +93,7 @@ void ExtensionPopup::Observe(int type,

// Show when the content finishes loading and its width is computed.

ShowBubble();

break;

- case chrome::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE:

+ case extensions::NOTIFICATION_EXTENSION_HOST_VIEW_SHOULD_CLOSE:

// If we aren't the host of the popup, then disregard the notification.

if (content::Details<extensions::ExtensionHost>(host()) == details)

GetWidget()->Close();