[DevTools] Remove SDKModels' fromTarget methods

[DevTools] Remove SDKModels' fromTarget methods

One can use target.model(ModelClass) now.
Fixed a couple of bugs along the way which could have accessed null models.

BUG=none

Review-Url: https://codereview.chromium.org/2782773002
Cr-Commit-Position: refs/heads/master@{#461304}
Committed: https://chromium.googlesource.com/chromium/src/+/7d149ef5473e980f0b3babd4d0f2839cb9338e73

[dgozman, 2017-03-29 00:53:07]

Description was changed from

==========
[DevTools] Patch for Joel

BUG=none
==========

to

==========
[DevTools] Patch for Joel

BUG=none
==========

[dgozman, 2017-03-29 00:53:07]

dgozman@chromium.org changed reviewers:
+ einbinder@chromium.org

[dgozman, 2017-03-29 00:55:15]

Description was changed from

==========
[DevTools] Patch for Joel

BUG=none
==========

to

==========
[DevTools] Remove SDKModels' fromTarget methods

One can use target.model(ModelClass) now.
Fixed a couple of bugs along the way which could have accessed null models.

BUG=none
==========

[dgozman, 2017-03-29 00:55:36]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-03-29 00:55:36]

Could you please take a look?

[caseq, 2017-03-29 17:48:43]

lgtm

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:146:
this.target().model(SDK.DOMModel).nodeHighlightRequested(node.id);
just do this.deferredDOMNode().highlight() instead. Perhaps even inline calls to
this method.

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:918:
var resourceTreeModel = target ? target.model(SDK.ResourceTreeModel) : null;
nit: keep && for consistency.

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:82: var
frame = this.target().model(SDK.ResourceTreeModel).frameForId(this.frameId);
this._cssModel.target()... and nuke the remaining mentions of target() (i.e.
line 53 et al.)?

[dgozman, 2017-04-01 00:22:44]

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityModel.js:146:
this.target().model(SDK.DOMModel).nodeHighlightRequested(node.id);
On 2017/03/29 17:48:42, caseq wrote:
> just do this.deferredDOMNode().highlight() instead. Perhaps even inline calls
to
> this method.

Done.

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:918:
var resourceTreeModel = target ? target.model(SDK.ResourceTreeModel) : null;
On 2017/03/29 17:48:42, caseq wrote:
> nit: keep && for consistency.

Done.

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
(right):

https://codereview.chromium.org/2782773002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js:82: var
frame = this.target().model(SDK.ResourceTreeModel).frameForId(this.frameId);
On 2017/03/29 17:48:42, caseq wrote:
> this._cssModel.target()... and nuke the remaining mentions of target() (i.e.
> line 53 et al.)?

Done.

[dgozman, 2017-04-01 00:22:49]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-01 00:22:50]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2782773002/#ps20001
(title: "addressed review comments")

[commit-bot: I haz the power, 2017-04-01 00:23:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 01:52:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491006169570820,
"parent_rev": "625244e25254fb6479b3122d92145c596616a196", "commit_rev":
"7d149ef5473e980f0b3babd4d0f2839cb9338e73"}

[commit-bot: I haz the power, 2017-04-01 01:53:05]

Description was changed from

==========
[DevTools] Remove SDKModels' fromTarget methods

One can use target.model(ModelClass) now.
Fixed a couple of bugs along the way which could have accessed null models.

BUG=none
==========

to

==========
[DevTools] Remove SDKModels' fromTarget methods

One can use target.model(ModelClass) now.
Fixed a couple of bugs along the way which could have accessed null models.

BUG=none

Review-Url: https://codereview.chromium.org/2782773002
Cr-Commit-Position: refs/heads/master@{#461304}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d149ef5473e980f0b3babd4d0f2...
==========

[commit-bot: I haz the power, 2017-04-01 01:53:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d149ef5473e980f0b3babd4d0f2...