Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index 1d4462d1ced051bc50d7899ad6ec0241ed58ab7d..6bc82d010d84d0585b0595f006113f1d0655908b 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -948,7 +948,7 @@ SDK.DeferredDOMNode = class {
* @param {number} backendNodeId
*/
constructor(target, backendNodeId) {
- this._domModel = SDK.DOMModel.fromTarget(target);
+ this._domModel = target.model(SDK.DOMModel);
this._backendNodeId = backendNodeId;
}
@@ -1086,7 +1086,7 @@ SDK.DOMModel = class extends SDK.SDKModel {
* @param {!SDK.RemoteObject} object
*/
static highlightObjectAsDOMNode(object) {
- var domModel = SDK.DOMModel.fromTarget(object.runtimeModel().target());
+ var domModel = object.runtimeModel().target().model(SDK.DOMModel);
if (domModel)
domModel.highlightDOMNode(undefined, undefined, undefined, object.objectId);
}
@@ -1111,14 +1111,6 @@ SDK.DOMModel = class extends SDK.SDKModel {
}
/**
- * @param {!SDK.Target} target
- * @return {?SDK.DOMModel}
- */
- static fromTarget(target) {
- return target.model(SDK.DOMModel);
- }
-
- /**
* @param {!SDK.DOMNode} node
*/
_scheduleMutationEvent(node) {

Powered by Google App Engine
This is Rietveld 408576698