third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

index 0800accc4ec0dd9b13db1716fc53edc54b19fbad..c8fcef6b4b23303962c7fbecd76161de963e4523 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

@@ -253,7 +253,7 @@ Sources.NavigatorView = class extends UI.VBox {

var frame = Bindings.NetworkProject.frameForProject(uiSourceCode.project());

if (!frame) {

var target = Bindings.NetworkProject.targetForProject(uiSourceCode.project());

- var resourceTreeModel = target && SDK.ResourceTreeModel.fromTarget(target);

+ var resourceTreeModel = target && target.model(SDK.ResourceTreeModel);

frame = resourceTreeModel && resourceTreeModel.mainFrame;

}

return frame;

@@ -440,7 +440,7 @@ Sources.NavigatorView = class extends UI.VBox {

function hoverCallback(hovered) {

if (hovered) {

- var domModel = SDK.DOMModel.fromTarget(target);

+ var domModel = target.model(SDK.DOMModel);

if (domModel)

domModel.highlightFrame(frame.id);

} else {