third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

index 1c45cbb71d43dab826e883b480500cbf7ec8dee4..7e627659bc2c454a9d299fb5ee5776d67195603c 100644

--- a/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

+++ b/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js

@@ -39,8 +39,8 @@ Screencast.ScreencastView = class extends UI.VBox {

super();

this._target = screenCaptureModel.target();

this._screenCaptureModel = screenCaptureModel;

- this._domModel = SDK.DOMModel.fromTarget(this._target);

- this._resourceTreeModel = SDK.ResourceTreeModel.fromTarget(this._target);

+ this._domModel = this._target.model(SDK.DOMModel);

+ this._resourceTreeModel = this._target.model(SDK.ResourceTreeModel);

this.setMinimumSize(150, 150);

this.registerRequiredCSS('screencast/screencastView.css');