Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
index d586241f4805d4a1157c889ca3d8833f6b851b2b..dec3afbe0bf96e1ce5ee45bb8fe9e425cd37c900 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
@@ -32,9 +32,8 @@
* @return {?SDK.Resource}
*/
Bindings.resourceForURL = function(url) {
- var targets = SDK.targetManager.targets(SDK.Target.Capability.DOM);
- for (var i = 0; i < targets.length; ++i) {
- var resource = SDK.ResourceTreeModel.fromTarget(targets[i]).resourceForURL(url);
+ for (var resourceTreeModel of SDK.targetManager.models(SDK.ResourceTreeModel)) {
+ var resource = resourceTreeModel.resourceForURL(url);
if (resource)
return resource;
}
@@ -45,9 +44,8 @@ Bindings.resourceForURL = function(url) {
* @param {function(!SDK.Resource)} callback
*/
Bindings.forAllResources = function(callback) {
- var targets = SDK.targetManager.targets(SDK.Target.Capability.DOM);
- for (var i = 0; i < targets.length; ++i)
- SDK.ResourceTreeModel.fromTarget(targets[i]).forAllResources(callback);
+ for (var resourceTreeModel of SDK.targetManager.models(SDK.ResourceTreeModel))
+ resourceTreeModel.forAllResources(callback);
};
/**

Powered by Google App Engine
This is Rietveld 408576698