Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
index e47760e0cd71bba41470b850405cb7b3505ede99..132bcdb1f932991816cfc8ec94b3c4f89d655300 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
@@ -125,7 +125,9 @@ Resources.ResourcesPanel = class extends UI.PanelWithSidebar {
* @param {string} cookieDomain
*/
showCookies(cookieFrameTarget, cookieDomain) {
- var model = SDK.CookieModel.fromTarget(cookieFrameTarget);
+ var model = cookieFrameTarget.model(SDK.CookieModel);
+ if (!model)
+ return;
if (!this._cookieView)
this._cookieView = new Resources.CookieItemsView(model, cookieDomain);
else
@@ -149,7 +151,10 @@ Resources.ResourcesPanel = class extends UI.PanelWithSidebar {
* @param {string} cookieDomain
*/
clearCookies(target, cookieDomain) {
- SDK.CookieModel.fromTarget(target).clear(cookieDomain, () => {
+ var model = target.model(SDK.CookieModel);
+ if (!model)
+ return;
+ model.clear(cookieDomain, () => {
if (this._cookieView)
this._cookieView.refreshItems();
});

Powered by Google App Engine
This is Rietveld 408576698