third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 4cef0d366be55bae10ee8ff96e56376d9abfc7d1..a7b45eae356735ed52902825c5559734148d9007 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -392,7 +392,7 @@ Network.NetworkLogView = class extends UI.VBox {

targetAdded(target) {

if (!target.parentTarget()) {

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);

+ var resourceTreeModel = target.model(SDK.ResourceTreeModel);

if (resourceTreeModel) {

resourceTreeModel.addEventListener(

SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavigated, this);

@@ -410,7 +410,7 @@ Network.NetworkLogView = class extends UI.VBox {

targetRemoved(target) {

if (!target.parentTarget()) {

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);

+ var resourceTreeModel = target.model(SDK.ResourceTreeModel);

if (resourceTreeModel) {

resourceTreeModel.removeEventListener(

SDK.ResourceTreeModel.Events.MainFrameNavigated, this._mainFrameNavigated, this);