third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/layers/LayersPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js b/third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js

index a337b0122cd4e054c253b7469cbd6d61ab8c73dd..1600d39b1515eb619f09ff6017570d0b8caa3a40 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/ExecutionContextSelector.js

@@ -129,7 +129,7 @@ Main.ExecutionContextSelector = class {

return false;

if (executionContext.target().parentTarget())

return false;

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(executionContext.target());

+ var resourceTreeModel = executionContext.target().model(SDK.ResourceTreeModel);

var frame = resourceTreeModel && resourceTreeModel.frameForId(executionContext.frameId);

if (frame && frame.isMainFrame())

return true;