Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
index 5872f2a912373b0c80ce00d02934587b130b043a..c7ff8142f0953929f649b92c7fcd3f6927a64111 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/**
- * @implements {SDK.TargetManager.Observer}
+ * @implements {SDK.SDKModelObserver<!SDK.ResourceTreeModel>}
* @unrestricted
*/
Resources.AppManifestView = class extends UI.VBox {
@@ -51,19 +51,16 @@ Resources.AppManifestView = class extends UI.VBox {
this._orientationField = this._presentationSection.appendField(Common.UIString('Orientation'));
this._displayField = this._presentationSection.appendField(Common.UIString('Display'));
- SDK.targetManager.observeTargets(this, SDK.Target.Capability.DOM);
+ SDK.targetManager.observeModels(SDK.ResourceTreeModel, this);
}
/**
* @override
- * @param {!SDK.Target} target
+ * @param {!SDK.ResourceTreeModel} resourceTreeModel
*/
- targetAdded(target) {
+ modelAdded(resourceTreeModel) {
if (this._resourceTreeModel)
return;
- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
- if (!resourceTreeModel)
- return;
this._resourceTreeModel = resourceTreeModel;
this._updateManifest();
resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.MainFrameNavigated, this._updateManifest, this);
@@ -71,10 +68,9 @@ Resources.AppManifestView = class extends UI.VBox {
/**
* @override
- * @param {!SDK.Target} target
+ * @param {!SDK.ResourceTreeModel} resourceTreeModel
*/
- targetRemoved(target) {
- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
+ modelRemoved(resourceTreeModel) {
if (!this._resourceTreeModel || this._resourceTreeModel !== resourceTreeModel)
return;
resourceTreeModel.removeEventListener(SDK.ResourceTreeModel.Events.MainFrameNavigated, this._updateManifest, this);

Powered by Google App Engine
This is Rietveld 408576698