third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/SecurityOriginManager.js ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

index 68e562a1ef8d774f26f56c358204c8a5a8e590be..e04e96c95123748a22a5a206c829fcff9433460b 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

@@ -17,20 +17,12 @@ SDK.ServiceWorkerCacheModel = class extends SDK.SDKModel {

this._agent = target.cacheStorageAgent();

- this._securityOriginManager = SDK.SecurityOriginManager.fromTarget(target);

+ this._securityOriginManager = target.model(SDK.SecurityOriginManager);

/** @type {boolean} */

this._enabled = false;

}

- /**

- * @param {!SDK.Target} target

- * @return {?SDK.ServiceWorkerCacheModel}

- */

- static fromTarget(target) {

- return target.model(SDK.ServiceWorkerCacheModel);

- }

enable() {

if (this._enabled)

return;