Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
index a1b49efe4536bf81bfb30d527ee073c31a2bb153..ab810bc7b6dcf3acefdc1619dbe33781d375f601 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
@@ -481,8 +481,8 @@ Extensions.ExtensionServer = class extends Common.Object {
uiSourceCodes =
uiSourceCodes.concat(Workspace.workspace.uiSourceCodesForProjectType(Workspace.projectTypes.ContentScripts));
uiSourceCodes.forEach(pushResourceData.bind(this));
- for (var target of SDK.targetManager.targets(SDK.Target.Capability.DOM))
- SDK.ResourceTreeModel.fromTarget(target).forAllResources(pushResourceData.bind(this));
+ for (var resourceTreeModel of SDK.targetManager.models(SDK.ResourceTreeModel))
+ resourceTreeModel.forAllResources(pushResourceData.bind(this));
return resources.valuesArray();
}
@@ -915,7 +915,7 @@ Extensions.ExtensionServer = class extends Common.Object {
frame = resolveURLToFrame(options.frameURL);
} else {
var target = SDK.targetManager.mainTarget();
- var resourceTreeModel = target && SDK.ResourceTreeModel.fromTarget(target);
+ var resourceTreeModel = target && target.model(SDK.ResourceTreeModel);
frame = resourceTreeModel && resourceTreeModel.mainFrame;
}
if (!frame) {

Powered by Google App Engine
This is Rietveld 408576698