Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
index 32f7b0222ec62bee3f83e07e295a292bf26ec785..508c6da710c50b30f1f80e91787936d0840833ba 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
@@ -34,8 +34,8 @@ function test()
InspectorTest.addResult("Adding page target");
var pageTarget = createMockTarget("page-target", SDK.Target.Capability.AllForTests, true /* dontAttachToMain */);
var pageRuntimeModel = pageTarget.model(SDK.RuntimeModel);
- SDK.ResourceTreeModel.fromTarget(pageTarget)._frameAttached('42', '');
- SDK.ResourceTreeModel.fromTarget(pageTarget)._frameNavigated({id: '42', parentId: '', loaderId: '', name: 'mock-frame', url: 'mock-url.com/frame.html', securityOrigin: 'mock-security-origin', mineType: 'mimeType'});
+ pageTarget.model(SDK.ResourceTreeModel)._frameAttached('42', '');
+ pageTarget.model(SDK.ResourceTreeModel)._frameNavigated({id: '42', parentId: '', loaderId: '', name: 'mock-frame', url: 'mock-url.com/frame.html', securityOrigin: 'mock-security-origin', mineType: 'mimeType'});
pageRuntimeModel._executionContextCreated({id: "cs1", auxData: { isDefault: false, frameId: "42" }, origin: "origin", name: "contentScript1"});
pageRuntimeModel._executionContextCreated({id: "if1", auxData: { isDefault: true, frameId: "iframe1" }, origin: "origin", name: "iframeContext1"});
pageRuntimeModel._executionContextCreated({id: "p1", auxData: { isDefault: true, frameId: "42" }, origin: "origin", name: "pageContext1Name"});

Powered by Google App Engine
This is Rietveld 408576698