Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js
index 88231a0ceb5f8c61a5d82820cf8033e09c15d800..43ecf0d83859b1ee72a31c2abdf79de2203b3acd 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesSection.js
@@ -22,7 +22,7 @@ Resources.ResourcesSection = class {
addListener(SDK.ResourceTreeModel.Events.ResourceAdded, this._resourceAdded, this);
var mainTarget = SDK.targetManager.mainTarget();
- var resourceTreeModel = mainTarget && mainTarget.hasDOMCapability() && SDK.ResourceTreeModel.fromTarget(mainTarget);
+ var resourceTreeModel = mainTarget && mainTarget.model(SDK.ResourceTreeModel);
var mainFrame = resourceTreeModel && resourceTreeModel.mainFrame;
if (mainFrame)
this._populateFrame(mainFrame);
@@ -39,8 +39,7 @@ Resources.ResourcesSection = class {
var parentTarget = frame.target().parentTarget();
if (!parentTarget)
return null;
- console.assert(parentTarget.hasDOMCapability());
- return SDK.ResourceTreeModel.fromTarget(parentTarget).mainFrame;
+ return parentTarget.model(SDK.ResourceTreeModel).mainFrame;
}
/**
@@ -165,7 +164,7 @@ Resources.FrameTreeElement = class extends Resources.BaseStorageTreeElement {
set hovered(hovered) {
if (hovered) {
this.listItemElement.classList.add('hovered');
- var domModel = SDK.DOMModel.fromTarget(this._frame.target());
+ var domModel = this._frame.target().model(SDK.DOMModel);
if (domModel)
domModel.highlightFrame(this._frameId);
} else {

Powered by Google App Engine
This is Rietveld 408576698