third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

index cd0c0c92fc66bc389bcbbe496b6df3ac51b0ad38..960c9e1bd90c07cb65ecf57d79e7741bb3d68562 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

@@ -153,7 +153,7 @@ Components.DOMPresentationUtils.linkifyDeferredNodeReference = function(deferred

Components.DOMPresentationUtils.buildImagePreviewContents = function(

target, originalImageURL, showDimensions, precomputedFeatures) {

- var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);

+ var resourceTreeModel = target.model(SDK.ResourceTreeModel);

if (!resourceTreeModel)

return Promise.resolve(/** @type {?Element} */ (null));

var resource = resourceTreeModel.resourceForURL(originalImageURL);