third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

index fd7d8d5c8b6d7cfee54c2f7cab033081ecb82609..2a7b989c782308a7f409f0bf2923059dde695c22 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditExtensionCategory.js

@@ -222,7 +222,7 @@ Audits.AuditExtensionFormatters = {

async function append(remoteObject) {

if (!remoteObject.isNode())

return;

- var domModel = SDK.DOMModel.fromTarget(remoteObject.runtimeModel().target());

+ var domModel = remoteObject.runtimeModel().target().model(SDK.DOMModel);

if (!domModel)

return;

var node = await domModel.pushObjectAsNodeToFrontend(remoteObject);