third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

index fc601e42435b6910234615d2fd1c42cfadc59d40..45d11b2f83703d93960fda1e430683201842c8f5 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

@@ -44,7 +44,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {

constructor(target, requestId, url, documentURL, frameId, loaderId, initiator) {

super(target);

- this._networkManager = /** @type {!SDK.NetworkManager} */ (SDK.NetworkManager.fromTarget(target));

+ this._networkManager = /** @type {!SDK.NetworkManager} */ (target.model(SDK.NetworkManager));

this._requestId = requestId;

this.setUrl(url);

this._documentURL = documentURL;