third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js - Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)

Patch Set: addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js b/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js

index b560767caa2cfa39b318f681e11fd43936a236a3..ce997a42407ba30237609e4f194318403d9d441e 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/TouchModel.js

@@ -54,7 +54,7 @@ Emulation.MultitargetTouchModel = class {

if (this._customTouchEnabled)

current = {enabled: true, configuration: 'mobile'};

- var domModel = SDK.DOMModel.fromTarget(target);

+ var domModel = target.model(SDK.DOMModel);

var inspectModeEnabled = domModel ? domModel.inspectModeEnabled() : false;

if (inspectModeEnabled)

current = {enabled: false, configuration: 'mobile'};

@@ -116,7 +116,7 @@ Emulation.MultitargetTouchModel = class {

* @param {!SDK.Target} target

targetAdded(target) {

- var domModel = SDK.DOMModel.fromTarget(target);

+ var domModel = target.model(SDK.DOMModel);

if (domModel)

domModel.addEventListener(SDK.DOMModel.Events.InspectModeWillBeToggled, this._inspectModeToggled, this);

this._applyToTarget(target);

@@ -127,7 +127,7 @@ Emulation.MultitargetTouchModel = class {

* @param {!SDK.Target} target

targetRemoved(target) {

- var domModel = SDK.DOMModel.fromTarget(target);

+ var domModel = target.model(SDK.DOMModel);

if (domModel)

domModel.removeEventListener(SDK.DOMModel.Events.InspectModeWillBeToggled, this._inspectModeToggled, this);

}