Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js

Issue 2782773002: [DevTools] Remove SDKModels' fromTarget methods (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
index c1adf632fa834e389d30f59c04f456f23b0b2923..2b76773b05e14eba9ea303eda81ae8a82a8cddbd 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js
@@ -953,7 +953,7 @@ Audits.AuditRules.CssInHeadRule = class extends Audits.AuditRule {
* @param {!Common.Progress} progress
*/
doRun(target, requests, result, callback, progress) {
- var domModel = SDK.DOMModel.fromTarget(target);
+ var domModel = target.model(SDK.DOMModel);
if (!domModel) {
callback(null);
return;
@@ -1064,7 +1064,7 @@ Audits.AuditRules.StylesScriptsOrderRule = class extends Audits.AuditRule {
* @param {!Common.Progress} progress
*/
doRun(target, requests, result, callback, progress) {
- var domModel = SDK.DOMModel.fromTarget(target);
+ var domModel = target.model(SDK.DOMModel);
if (!domModel) {
callback(null);
return;
@@ -1315,7 +1315,11 @@ Audits.AuditRules.CookieRuleBase = class extends Audits.AuditRule {
}
const nonDataUrls = requests.map(r => r.url()).filter(url => url && url.asParsedURL());
- SDK.CookieModel.fromTarget(target).getCookiesAsync(nonDataUrls, resultCallback);
+ var cookieModel = target.model(SDK.CookieModel);
+ if (cookieModel)
+ cookieModel.getCookiesAsync(nonDataUrls, resultCallback);
+ else
+ callback(result);
}
mapResourceCookies(requestsByDomain, allCookies, callback) {

Powered by Google App Engine
This is Rietveld 408576698